doc: include license for src/large_pages in LICENSE#25246
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: nodejs#25238
nodejs-github-bot added meta 
ContributorAuthor
ryzokuken commented Dec 28, 2018
Trott approved these changes Dec 28, 2018
ContributorAuthor
ryzokuken commented Dec 28, 2018
Since the weekend is kicking around and this change is almost purely cosmetic, please respond with 👍 to suggest fast-tracking this. |
lpinca approved these changes Dec 28, 2018
Contributor
kapouer commented Dec 28, 2018
LGTM. |
kapouer approved these changes Dec 28, 2018
addaleax approved these changes Dec 30, 2018
Member
addaleax commented Dec 30, 2018
addaleax added the author ready 
Member
Resume Build CI (scheduled): https://ci.nodejs.org/job/node-test-pull-request/19888/ ✅ |
Member
Trott commented Dec 31, 2018
Landed in 48a88c8 |
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 31, 2018
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: nodejs#25238 PR-URL: nodejs#25246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jan 1, 2019
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: #25238 PR-URL: #25246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: nodejs#25238 PR-URL: nodejs#25246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: #25238 PR-URL: #25246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: #25238 PR-URL: #25246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Include License for src/large_pages (MIT licensed by Intel), to the main LICENSE file and make required changes to the tools/license-builder.sh script. Fixes: #25238 PR-URL: #25246 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.
Fixes: #25238
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @Trott@kapouer