Skip to content

Conversation

@ZYSzys
Copy link
Member

We test fs.fchmod function in test-fs-fchmod.js, so the test snippet in test-fs-chmod.js is redundant and remove it now.

// Check input type
[false,null,undefined,{},[],''].forEach((input)=>{
consterrObj={
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
message: 'The "fd" argument must be of type number. Received type '+
typeofinput
};
assert.throws(()=>fs.fchmod(input),errObj);
assert.throws(()=>fs.fchmodSync(input),errObj);
});

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2018
@danbev
Copy link
Contributor

@addaleax
Copy link
Member

Landed in ff0f99b 🎉

@addaleaxaddaleax closed this Jan 7, 2019
addaleax pushed a commit that referenced this pull request Jan 7, 2019
@ZYSzysZYSzys deleted the test-fs-remove branch January 7, 2019 23:56
addaleax pushed a commit that referenced this pull request Jan 9, 2019
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeARBridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
BethGriggs pushed a commit that referenced this pull request May 10, 2019
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ZYSzys@danbev@addaleax@lpinca@nodejs-github-bot