worker: use engine-provided deleter for SharedArrayBuffers#25307
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Store the full information we have on a given `SharedArrayBuffer`, and use the deleter provided by the JS engine to free the memory when that is needed. This fixes memory lifetime management for WASM buffers that are passed through a `MessageChannel` (e.g. between threads).
nodejs-github-bot added the c++ 
devsnek approved these changes Jan 1, 2019
devsnek added experimental 
MemberAuthor
addaleax commented Jan 1, 2019
jasnell approved these changes Jan 1, 2019
MemberAuthor
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19907/ (:heavy_check_mark:) |
addaleax added the author ready 
TimothyGu approved these changes Jan 2, 2019
MemberAuthor
addaleax commented Jan 2, 2019
Fwiw, I’ve extended the test a bit. (@devsnek I’ve also figured out that we can’t transfer New CI: https://ci.nodejs.org/job/node-test-pull-request/19915/ |
3 tasks
MemberAuthor
addaleax commented Jan 3, 2019
Fixed the extended test on Windows. New CI: https://ci.nodejs.org/job/node-test-pull-request/19918/ |
MemberAuthor
addaleax commented Jan 3, 2019
Landed in 1f1a373 |
addaleax added a commit that referenced this pull request Jan 3, 2019
Store the full information we have on a given `SharedArrayBuffer`, and use the deleter provided by the JS engine to free the memory when that is needed. This fixes memory lifetime management for WASM buffers that are passed through a `MessageChannel` (e.g. between threads). PR-URL: #25307 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
addaleax added a commit that referenced this pull request Jan 5, 2019
Store the full information we have on a given `SharedArrayBuffer`, and use the deleter provided by the JS engine to free the memory when that is needed. This fixes memory lifetime management for WASM buffers that are passed through a `MessageChannel` (e.g. between threads). PR-URL: #25307 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Store the full information we have on a given `SharedArrayBuffer`, and use the deleter provided by the JS engine to free the memory when that is needed. This fixes memory lifetime management for WASM buffers that are passed through a `MessageChannel` (e.g. between threads). PR-URL: nodejs#25307 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
Store the full information we have on a given `SharedArrayBuffer`, and use the deleter provided by the JS engine to free the memory when that is needed. This fixes memory lifetime management for WASM buffers that are passed through a `MessageChannel` (e.g. between threads). PR-URL: nodejs#25307 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @devsnek for reporting this and coming up with a test case!
Store the full information we have on a given
SharedArrayBuffer,and use the deleter provided by the JS engine to free the memory
when that is needed.
This fixes memory lifetime management for WASM buffers that are
passed through a
MessageChannel(e.g. between threads).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes