Skip to content

tools: update crypo check rule#25399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjihrig wants to merge 1 commit into from
Closed

tools: update crypo check rule #25399

cjihrig wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Jan 8, 2019

This commit updates the custom crypto-check ESLint rule to detect require() calls that come before all hasCrypto checks.

Refs: #25388

Note: This will fail CI until #25388 lands.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig
tools: update crypo check rule
d9e8451
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks.
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 8, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 8, 2019

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2184/pipeline

@danbev
Copy link
Contributor

danbev commented Jan 11, 2019

Landed in 4c9ea8f.

@danbevdanbev closed this Jan 11, 2019
danbev pushed a commit that referenced this pull request Jan 11, 2019
@cjihrig@danbev
tools: update crypo check rule
4c9ea8f
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks. PR-URL: #25399 Refs: #25388 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@cjihrigcjihrig deleted the crypto-lint branch January 11, 2019 20:26
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@cjihrig@addaleax
tools: update crypo check rule
2a85cc7
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks. PR-URL: #25399 Refs: #25388 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@cjihrig@BridgeAR
tools: update crypo check rule
bf66935
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks. PR-URL: nodejs#25399 Refs: nodejs#25388 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig@BethGriggs
tools: update crypo check rule
05b71f1
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks. PR-URL: #25399 Refs: #25388 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@cjihrig@BethGriggs
tools: update crypo check rule
e7e0a1f
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks. PR-URL: #25399 Refs: #25388 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig@MylesBorins
tools: update crypo check rule
21500a8
This commit updates the custom crypto-check ESLint rule to detect require() calls that come before any hasCrypto checks. PR-URL: #25399 Refs: #25388 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 9, 2020
Open
Open
Open
Open
Open
Open
Merged
@snyk-botsnyk-bot mentioned this pull request Oct 29, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@richardlaurichardlaurichardlau approved these changes

+1 more reviewer

@danbevdanbevdanbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@nodejs-github-bot@danbev@jasnell@richardlau