doc: os.networkInterfaces() example outdated#25417
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. Fixes: #25408
nodejs-github-bot added doc 
Contributor
vsemozhetbyt commented Jan 9, 2019
BridgeAR approved these changes Jan 10, 2019
BridgeAR added the author ready 
starkwang approved these changes Jan 11, 2019
Contributor
vsemozhetbyt commented Jan 11, 2019
Landed in c380ea1 |
vsemozhetbyt pushed a commit that referenced this pull request Jan 11, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: #25417Fixes: #25408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: #25417Fixes: #25408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: nodejs#25417Fixes: nodejs#25408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: #25417Fixes: #25408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: #25417Fixes: #25408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
The os.networkInterfaces() example was outdated as the IPv6 interfaces did not include the scopeid property, now they do. PR-URL: #25417Fixes: #25408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the
scopeidproperty,now they do.
Fixes: #25408
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes