test: refactor two http client timeout tests#25473
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 13, 2019
@lpinca sadly an error occured when I tried to trigger a build :( |
MemberAuthor
lpinca commented Jan 13, 2019
lpincaforce-pushed the remove/unneeded-timers branch from 6db4080 to d10b021CompareMemberAuthor
lpinca commented Jan 15, 2019
This was referenced Jan 16, 2019
lpincaforce-pushed the remove/unneeded-timers branch from d10b021 to f27b501CompareRefactor test-http-client-set-timeout and test-http-client-timeout-option-with-agent.
lpincaforce-pushed the remove/unneeded-timers branch from f27b501 to 95e6baaComparelpinca changed the title MemberAuthor
lpinca commented Feb 7, 2019
New CI: https://ci.nodejs.org/job/node-test-pull-request/20636/ |
Member
Trott commented Feb 9, 2019
Resume Build CI; https://ci.nodejs.org/job/node-test-pull-request/20679/ |
Trott approved these changes Feb 9, 2019
Member
Trott commented Feb 9, 2019
@nodejs/http |
jasnell approved these changes Feb 11, 2019
MemberAuthor
lpinca commented Feb 12, 2019
Landed in b361f95. |
lpinca added a commit that referenced this pull request Feb 12, 2019
Refactor test-http-client-set-timeout and test-http-client-timeout-option-with-agent. PR-URL: #25473 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
Refactor test-http-client-set-timeout and test-http-client-timeout-option-with-agent. PR-URL: #25473 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor test-http-client-set-timeout and test-http-client-timeout-option-with-agent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes