Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
http: make timeout event work with agent timeout#25488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Jan 14, 2019
@lpinca sadly an error occured when I tried to trigger a build :( |
f4f3182 to 07a6300Comparelpinca commented Jan 14, 2019
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set.
07a6300 to 772c28bComparelpinca commented Jan 21, 2019 • edited by addaleax
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by addaleax
Uh oh!
There was an error while loading. Please reload this page.
cc: @nodejs/http |
addaleax commented Jan 28, 2019
@lpinca Do you want to merge this? |
lpinca commented Jan 29, 2019
@addaleax let's wait a little more for another approval, it's not a critical issue. We can merge this in a couple of days if nothing changed. Thank you. |
lpinca commented Jan 31, 2019
Landed in 4b6e4c1. |
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set. PR-URL: #25488 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos commented Jan 31, 2019
The test added in this PR fails on my computer: |
lpinca commented Jan 31, 2019
Ok, I will change it to prevent it from using a non routable IP address so it will not be flaky. I'll get to it as soon as I can. |
Fix flakyness caused by usage of a non-routable IP address. Refs: nodejs#25488 (comment)
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set. PR-URL: #25488 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fix flakyness caused by usage of a non-routable IP address. Refs: nodejs#25488 (comment) PR-URL: nodejs#25854 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Fix flakyness caused by usage of a non-routable IP address. Refs: #25488 (comment) PR-URL: #25854 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
The
'timeout'event is currently not emitted on theClientRequestinstance when the socket timeout expires if only the
timeoutoptionof the agent is set. This happens because, under these circumstances,
listenSocketTimeout()is not called.This commit fixes the issue by calling it also when only the agent
timeoutoption is set.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes