test: revert fail coverage target if tests fail"

[mhdawson]

This reverts commit f216d5b.
Seems like it breaks the nightly job so reverting until
we figure that out.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@mhdawson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2271/pipeline

[mhdawson]

This needs to be reverted as we do have failing tests when run with coverage enabled (and have forever I think) so the original change prevents the gathering and printing of coverage information.

[mhdawson]

There is something up with the main coverage job as well, but testing locally I confirmed we need the revert

[mhdawson]

Would also like to fast track this.

[mhdawson]

CI run: https://ci.nodejs.org/job/node-test-pull-request/20181/

[mhdawson]

Coverage job CI run, shows that this resolves the issue: https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/2/

[mhdawson]

Renamed jobs as something was broken with the CI job for coverage even though coverage build locally. New CI which references the updated job: https://ci.nodejs.org/view/Node.js%20Daily/job/node-test-commit-linux-coverage/3/

[mhdawson]

Windows Node.js CI failure was known issue:#25512

Will resume build.

[mhdawson]

Build resumed: https://ci.nodejs.org/job/node-test-pull-request/20186/

[BridgeAR]

I marked this as do not land as the original commit is marked as such.

[mhdawson]

@BridgeAR thanks.

[mhdawson]

Strangely renaming a working job, with no other changes caused the job to fail so there is some state somewhere. I've cleared out the workspace, deleted the files on disk but that still did not help. I'm just going to leave it as the new name with "-daily" in the job name.

[mhdawson]

This link is now valid again https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/2/

[mhdawson]

Ok resumed CI job is green :).

[mhdawson]

Think I've got the ok's for fast-track, landing now.

[mhdawson]

Landed in 1375af2

[refack]

This needs to be reverted as we do have failing tests when run with coverage enabled (and have forever I think)

That's sounds like a sub-optimal situation. I'll try to look into that.

Cross-ref: #25432

[refack]

Strangely renaming a working job, with no other changes caused the job to fail so there is some state somewhere.

P.S. renaming the job the same name as the broken one caused Jenkins to reuse the broken workspace directory. It might store a broken compilation artifact.