tools: make mkssldef.py Python 3 compatible#25584
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3.
nodejs-github-bot added openssl 
refack approved these changes Jan 19, 2019
refack added the python 
cclauss approved these changes Jan 19, 2019
bnoordhuis approved these changes Jan 21, 2019
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
Left a comment but LGTM either way.
tools/mkssldef.py Outdated
| forlineinopen(filename).readlines(): | ||
| name, _, _, meta, _=re.split('\s+', line) | ||
| ifany(map(lambdap: p.match(name), excludes)): continue | ||
| ifany([p.match(name)forpinexcludes]): continue |
Member
There was a problem hiding this comment.
You don't need the square brackets here, any() accepts a generator.
ContributorAuthor
There was a problem hiding this comment.
Changed it to a generator now.
Member
addaleax commented Jan 27, 2019
addaleax added the author ready 
Contributor
Re-run of failing node-test-commit-windows-fanned ✔️ |
Contributor
danbev commented Jan 28, 2019
Landed in 4814987. |
danbev pushed a commit that referenced this pull request Jan 28, 2019
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3. PR-URL: #25584 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3. PR-URL: #25584 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3. PR-URL: #25584 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3. PR-URL: #25584 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
This patch replaces the usage of `map` in such a way that it will be compatible with Python 3. PR-URL: #25584 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces the usage of
mapin such a way that it will becompatible with Python 3.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/python @cclauss