build: remove erroneous duplicate declaration from node_inspector.gypi#25586
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
refack added inspector 
addaleax approved these changes Jan 19, 2019
cjihrig approved these changes Jan 19, 2019
refack added the author ready refackforce-pushed the inspector_gypi_oops branch from 85cd14b to 5b6a4e6CompareContributorAuthor
refack commented Jan 22, 2019
refack added a commit that referenced this pull request Jan 22, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
refackforce-pushed the inspector_gypi_oops branch from 5b6a4e6 to 5d80f9eCompareContributorAuthor
refack commented Jan 22, 2019
landed in 5d80f9e |
addaleax pushed a commit that referenced this pull request Jan 23, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops.
Duplicate/overriding declarations are on:
https://github.com/nodejs/node/blob/85cd14bd33443e81648a8f8b5eb911d909714fd3/src/inspector/node_inspector.gypi#L104
and
https://github.com/nodejs/node/blob/85cd14bd33443e81648a8f8b5eb911d909714fd3/src/inspector/node_inspector.gypi#L138
/CC @nodejs/build-files @nodejs/v8-inspector
CI: https://ci.nodejs.org/job/node-test-pull-request/20207/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes