test: replace common.PORT with 0 in https renegotiation test#25599
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Repeated use of common.PORT was resulting in sporadic failures on some operating systems.
addaleax approved these changes Jan 21, 2019
richardlau approved these changes Jan 21, 2019
cjihrig approved these changes Jan 21, 2019
MemberAuthor
Trott commented Jan 21, 2019
MemberAuthor
Trott commented Jan 23, 2019
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20274/ |
MemberAuthor
Trott commented Jan 23, 2019
Landed in c33d38b |
Trott added a commit to Trott/io.js that referenced this pull request Jan 23, 2019
Repeated use of common.PORT was resulting in sporadic failures on some operating systems. PR-URL: nodejs#25599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 23, 2019
Repeated use of common.PORT was resulting in sporadic failures on some operating systems. PR-URL: #25599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
Repeated use of common.PORT was resulting in sporadic failures on some operating systems. PR-URL: #25599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
Repeated use of common.PORT was resulting in sporadic failures on some operating systems. PR-URL: #25599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Repeated use of common.PORT was resulting in sporadic failures on some operating systems. PR-URL: #25599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes