test: run html/webappapis/timers WPT#25618
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
joyeecheung commented Jan 21, 2019
Using ``` git node wpt html/webappapis/timers ```
MemberAuthor
joyeecheung commented Jan 24, 2019
MemberAuthor
joyeecheung commented Jan 29, 2019
Ping @nodejs/testing |
jasnell approved these changes Jan 29, 2019
joyeecheung added the author ready MemberAuthor
joyeecheung commented Jan 30, 2019
MemberAuthor
joyeecheung commented Jan 31, 2019
CI was green, though node-test-commit got interrupted so the final status was red |
MemberAuthor
joyeecheung commented Jan 31, 2019
Landed in 4b6e4c1...d9066be |
joyeecheung added a commit that referenced this pull request Jan 31, 2019
Using ``` git node wpt html/webappapis/timers ``` PR-URL: #25618 Reviewed-By: James M Snell <[email protected]>
joyeecheung added a commit that referenced this pull request Jan 31, 2019
PR-URL: #25618 Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Using ``` git node wpt html/webappapis/timers ``` PR-URL: #25618 Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
PR-URL: #25618 Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: pull html/webappapis/timers WPT
Using
test: run html/webappapis/timers WPT
Note that currently only
missing-timeout-setinterval.any.jsgets run - other tests are not yet ported to .js in the upstream.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes