lib: refactor policy code for readability#25629
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Simplify a few particularly quirky bits of code, and add whitespace for readability.
nodejs-github-bot added the process 
lundibundi approved these changes Jan 21, 2019
| } | ||
| }=require('buffer'); | ||
| constBufferFrom=require('buffer').Buffer.from; |
cjihrig approved these changes Jan 21, 2019
devsnek approved these changes Jan 21, 2019
antsmartian approved these changes Jan 22, 2019
Contributor
antsmartian commented Jan 22, 2019
thefourtheye approved these changes Jan 22, 2019
addaleax added the author ready 
MemberAuthor
addaleax commented Jan 24, 2019
Contributor
danbev commented Jan 25, 2019
Landed in 0f5c14c. |
addaleax added a commit that referenced this pull request Jan 28, 2019
Simplify a few particularly quirky bits of code, and add whitespace for readability. PR-URL: #25629 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify a few particularly quirky bits of code, and add
whitespace for readability.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes