Skip to content

doc: document uniqueness of worker.threadId#25644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

doc: document uniqueness of worker.threadId #25644

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Jan 22, 2019

/cc @SimenB

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2019

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2343/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 22, 2019
@addaleaxaddaleax added the worker Issues and PRs related to Worker support. label Jan 22, 2019
@SimenB
Copy link
Member

SimenB commented Jan 22, 2019

Thanks for the clarification!

SimenB
SimenB reviewed Jan 22, 2019
View reviewed changes
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019
@danbev
Copy link
Contributor

danbev commented Jan 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20404/

@danbev
Copy link
Contributor

danbev commented Jan 29, 2019

Landed in 25e057e.

@danbevdanbev closed this Jan 29, 2019
danbev pushed a commit that referenced this pull request Jan 29, 2019
@addaleax@danbev
doc: document uniqueness of worker.threadId
25e057e
PR-URL: #25644 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax@targos
doc: document uniqueness of worker.threadId
c56ddc7
PR-URL: #25644 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@targostargos mentioned this pull request Jan 29, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

+2 more reviewers

@SimenBSimenBSimenB left review comments

@danbevdanbevdanbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@nodejs-github-bot@SimenB@danbev@cjihrig