doc: simplify process.binding() deprecation message#25654
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Keep the process.binding() deprecation message short and direct. In addition to the usual benefits of doing that, it also means the message is less likely to line-wrap once we move to a runtime deprecation.
nodejs-github-bot added deprecations 
vsemozhetbyt approved these changes Jan 23, 2019
Trott added the author ready 
cjihrig approved these changes Jan 23, 2019
lpinca approved these changes Jan 23, 2019
MemberAuthor
Trott commented Jan 25, 2019
Landed in 7d27f0e |
Trott added a commit to Trott/io.js that referenced this pull request Jan 25, 2019
Keep the process.binding() deprecation message short and direct. In addition to the usual benefits of doing that, it also means the message is less likely to line-wrap once we move to a runtime deprecation. PR-URL: nodejs#25654 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
Keep the process.binding() deprecation message short and direct. In addition to the usual benefits of doing that, it also means the message is less likely to line-wrap once we move to a runtime deprecation. PR-URL: #25654 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
Keep the process.binding() deprecation message short and direct. In addition to the usual benefits of doing that, it also means the message is less likely to line-wrap once we move to a runtime deprecation. PR-URL: #25654 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
Keep the process.binding() deprecation message short and direct. In addition to the usual benefits of doing that, it also means the message is less likely to line-wrap once we move to a runtime deprecation. PR-URL: #25654 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Keep the process.binding() deprecation message short and direct. In addition to the usual benefits of doing that, it also means the message is less likely to line-wrap once we move to a runtime deprecation. PR-URL: #25654 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the process.binding() deprecation message short and direct. In
addition to the usual benefits of doing that, it also means the message
is less likely to line-wrap once we move to a runtime deprecation.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes