test: fix renegotiation tests in pummel#25668
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With a recent OpenSSL update to core, a change in the behavior of `s_client` result in pummel test failures because they spam with renegotiation requests before the renegotiation is complete. Modify tests to reduce initial spamming. This fixes the TLS renegotiation test. While it fixes the bug in the HTTPS test too, that is still failing with the OpenSSL update for other (too-be-determined) reasons. Refs: nodejs#25381 (comment)
sam-github approved these changes Jan 23, 2019
MemberAuthor
Trott commented Jan 24, 2019
(Pummel tests not run in regular CI so lite test should be sufficient.) |
Trott added the author ready MemberAuthor
Trott commented Jan 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a recent OpenSSL update to core, a change in the behavior of
s_clientresult in pummel test failures because they spam withrenegotiation requests before the renegotiation is complete. Modify
tests to reduce initial spamming.
This fixes the TLS renegotiation test. While it fixes the bug in the
HTTPS test too, that is still failing with the OpenSSL update for other
(too-be-determined) reasons.
Refs: #25381 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes