test: remove pummel/test-exec#25722
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove redundant test/pummel/test-exec.js. Refs: nodejs#25686 (review)
addaleax approved these changes Jan 26, 2019
BethGriggs approved these changes Jan 26, 2019
cjihrig approved these changes Jan 26, 2019
MemberAuthor
Trott commented Jan 27, 2019
Trott added the author ready 
lpinca approved these changes Jan 27, 2019
jasnell approved these changes Jan 28, 2019
MemberAuthor
Trott commented Jan 28, 2019
Landed in 953dae1 |
Trott added a commit to Trott/io.js that referenced this pull request Jan 28, 2019
Remove redundant test/pummel/test-exec.js. Refs: nodejs#25686 (review) PR-URL: nodejs#25722 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
2 tasks
addaleax pushed a commit that referenced this pull request Jan 28, 2019
Remove redundant test/pummel/test-exec.js. Refs: #25686 (review) PR-URL: #25722 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant test/pummel/test-exec.js.
Refs: #25686 (review)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes