Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclausscclauss commented Jan 28, 2019

As recommended at #25759 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

As recommended at nodejs#25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 28, 2019
@cclausscclauss mentioned this pull request Jan 28, 2019
4 tasks
@Trott
Copy link
Member

@nodejs/build @nodejs/documentation

@Trott
Copy link
Member

@Trott
Copy link
Member

@nodejs/python

@Trott
Copy link
Member

@refackrefack added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 29, 2019
@refack
Copy link
Contributor

LGTM as a semver-major move for node12

@refackrefack added the python PRs and issues that require attention from people who are familiar with Python. label Jan 29, 2019
@Trott
Copy link
Member

@nodejs/tsc

@ofrobots
Copy link
Contributor

This is a FYI doc-only change. Why is this semver-major?

@refack
Copy link
Contributor

Why is this semver-major?

I think that a formal change in supported toolchains (i.e. no longer supporting Python2.6) should be semver-major.
Effectively this frees us to break compatibility with 2.6, and to stop testing with 2.6.

Copy link
Contributor

@ofrobotsofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I missed the 2.6 drop the first time around. Sorry about that.

LGTM.

@refack
Copy link
Contributor

I think semver-major/"breaking change" should be applied only to things that might break stuff for the end user.

FWIW, some end users do compile their own binary, and some users are downstream consumers in some way (embedders / tinkerers), so in that sense a change in the toolchain could break their usage.

@refackrefack self-assigned this Jan 30, 2019
@Trott
Copy link
Member

Even though this is going in as semver-major, I imagine we don't need a CITGM run for this, so I'll add the author ready label.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019
@addaleax
Copy link
Member

Landed in bb564a3

addaleax pushed a commit that referenced this pull request Jan 30, 2019
As recommended at #25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus PR-URL: #25766 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@cclausscclauss deleted the patch-3 branch January 30, 2019 23:50
@refackrefack removed their assignment Mar 11, 2019
@BethGriggsBethGriggs mentioned this pull request Mar 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.pythonPRs and issues that require attention from people who are familiar with Python.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@cclauss@Trott@refack@ofrobots@addaleax@thefourtheye@gengjiawen@nodejs-github-bot