Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
build: update prerequisites on progress towards Python 3#25766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
cclauss commented Jan 28, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
As recommended at nodejs#25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Trott commented Jan 28, 2019
@nodejs/build @nodejs/documentation |
Trott commented Jan 28, 2019
Co-Authored-By: cclauss <[email protected]>
Trott commented Jan 28, 2019
@nodejs/python |
Trott commented Jan 28, 2019
refack commented Jan 29, 2019
LGTM as a semver-major move for node12 |
Trott commented Jan 29, 2019
@nodejs/tsc |
ofrobots commented Jan 30, 2019
This is a FYI doc-only change. Why is this semver-major? |
refack commented Jan 30, 2019
I think that a formal change in supported toolchains (i.e. no longer supporting Python2.6) should be semver-major. |
ofrobots left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I missed the 2.6 drop the first time around. Sorry about that.
LGTM.
refack commented Jan 30, 2019
FWIW, some end users do compile their own binary, and some users are downstream consumers in some way (embedders / tinkerers), so in that sense a change in the toolchain could break their usage. |
Trott commented Jan 30, 2019
Even though this is going in as |
addaleax commented Jan 30, 2019
Landed in bb564a3 |
As recommended at #25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus PR-URL: #25766 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
As recommended at #25759 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes