Skip to content

worker: export workerData to ESM workers#25768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 2 commits into from
Closed

worker: export workerData to ESM workers #25768

addaleax wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Jan 28, 2019

Fixes: #25765

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleaxaddaleax added esm Issues and PRs related to the ECMAScript Modules implementation. worker Issues and PRs related to Worker support. labels Jan 28, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2019

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2420/pipeline

@addaleaxaddaleax mentioned this pull request Jan 28, 2019
Closed
@addaleax
Copy link
MemberAuthor

addaleax commented Jan 28, 2019•
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20374/ (:heavy_check_mark:)

devsnek
devsnek reviewed Jan 28, 2019
View reviewed changes
@GeorgeTaveras1231
Copy link

GeorgeTaveras1231 commented Jan 28, 2019

Impressive how quickly this was addressed. Thanks @addaleax!

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019
@addaleax
Copy link
MemberAuthor

addaleax commented Jan 30, 2019

Landed in 8919169

@addaleaxaddaleax deleted the worker-data-esm branch January 30, 2019 17:16
addaleax added a commit that referenced this pull request Jan 30, 2019
@addaleax
worker: export workerData to ESM workers
8919169
Fixes: #25765 PR-URL: #25768 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 30, 2019
@addaleax@targos
worker: export workerData to ESM workers
e0597a7
Fixes: #25765 PR-URL: #25768 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

+3 more reviewers

@devsnekdevsnekdevsnek approved these changes

@Fishrock123Fishrock123Fishrock123 approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

workerData export not available when using ES Modules

9 participants

@addaleax@nodejs-github-bot@GeorgeTaveras1231@jasnell@Fishrock123@lpinca@TimothyGu@cjihrig@devsnek