tools: bump cpplint.py to 3d8f6f876d#25771
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
refack added c++ 
cclauss approved these changes Jan 28, 2019
Trott added the author ready 
bnoordhuis approved these changes Jan 28, 2019
tools/cpplint.py Outdated
tools/cpplint.py Outdated
Member
There was a problem hiding this comment.
Indent error (or does this come from upstream?)
Contributor
There was a problem hiding this comment.
Google favors is 2 space indentation. There is a pretty good chance that this code was formatted with https://github.com/google/yapf
ContributorAuthor
There was a problem hiding this comment.
All white-space changes are lifted verbatim from https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
P.S. I'll refactor the commits to make that easier to review
refackforce-pushed the bump-cpplint-3d8f6f876d branch from ee8cbf3 to 6404279Compare63 tasks
ContributorAuthor
refack commented Jan 30, 2019
PR-URL: nodejs#25771Fixes: nodejs#25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
* Preserve 3 node-core checks * Preserve patch to `FileInfo.RepositoryName` * Remove TAP to logfile (unused) PR-URL: nodejs#25771Fixes: nodejs#25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
refackforce-pushed the bump-cpplint-3d8f6f876d branch from 6404279 to 4d19300Comparerefack removed the author ready addaleax pushed a commit that referenced this pull request Feb 1, 2019
PR-URL: #25771Fixes: #25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
* Preserve 3 node-core checks * Preserve patch to `FileInfo.RepositoryName` * Remove TAP to logfile (unused) PR-URL: #25771Fixes: #25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
/CC @nodejs/build-files @nodejs/python
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes