worker: throw for duplicates in transfer list#25815
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Throw a `DataCloneError` exception when encountering duplicate `ArrayBuffer`s or `MessagePort`s in the transfer list. Fixes: nodejs#25786
nodejs-github-bot added the c++ 
MemberAuthor
addaleax commented Jan 30, 2019
jasnell approved these changes Jan 30, 2019
MemberAuthor
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20448/ (:heavy_check_mark:) |
joyeecheung approved these changes Jan 30, 2019
richardlau approved these changes Jan 30, 2019
addaleax added the author ready 
cjihrig approved these changes Jan 30, 2019
MemberAuthor
addaleax commented Feb 1, 2019
Landed in 0ff0af5 |
addaleax added a commit that referenced this pull request Feb 1, 2019
Throw a `DataCloneError` exception when encountering duplicate `ArrayBuffer`s or `MessagePort`s in the transfer list. Fixes: #25786 PR-URL: #25815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax added a commit that referenced this pull request Feb 1, 2019
Throw a `DataCloneError` exception when encountering duplicate `ArrayBuffer`s or `MessagePort`s in the transfer list. Fixes: #25786 PR-URL: #25815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw a
DataCloneErrorexception when encountering duplicateArrayBuffers orMessagePorts in the transfer list.Fixes: #25786
(Fyi @chjj)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes