test: exclude additional test for coverage#25833
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on.
MemberAuthor
mhdawson commented Jan 30, 2019
@fyi #bcoe |
danbev approved these changes Jan 31, 2019
richardlau approved these changes Jan 31, 2019
test/root.status Outdated
| [$type==coverage] | ||
| js-native-api/test_function/test: PASS,FAIL,CRASH | ||
| js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH | ||
| async-hooks/test-callback-error: PASS,FAIL,CRASH |
Member
There was a problem hiding this comment.
Suggest sorting this (i.e. put this above the js-native-api tests).
MemberAuthor
mhdawson commented Jan 31, 2019
MemberAuthor
mhdawson commented Jan 31, 2019
Resume build due arm failures: https://ci.nodejs.org/job/node-test-pull-request/20495/ |
MemberAuthor
mhdawson commented Feb 1, 2019
Ok CI run good, will land once 48hours is up. |
bcoe approved these changes Feb 1, 2019
MemberAuthor
mhdawson commented Feb 1, 2019
Landed as c369b3e |
mhdawson added a commit that referenced this pull request Feb 1, 2019
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on. PR-URL: #25833 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ben Coe <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Exclude async-hooks/test-callback-error as it seems to fail consistently when run with coverage on the docker ubuntu16 machines we plan to run the coverage sanity test on. PR-URL: #25833 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude async-hooks/test-callback-error as it seems
to fail consistently when run with coverage on
the docker ubuntu16 machines we plan to run the
coverage sanity test on.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes