src: remove unused method in env.h#25934
Closed
+0 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: gengjiawen <[email protected]>
nodejs-github-bot added the c++ 
MemberAuthor
gengjiawen commented Feb 6, 2019
@addaleax Also this one, thanks. |
addaleax approved these changes Feb 6, 2019
jasnell approved these changes Feb 6, 2019
lpinca approved these changes Feb 6, 2019
Contributor
danbev commented Feb 8, 2019
Member
lpinca commented Feb 9, 2019
Member
lpinca commented Feb 9, 2019
Landed in c2d374f. |
lpinca pushed a commit that referenced this pull request Feb 9, 2019
Signed-off-by: gengjiawen <[email protected]> PR-URL: #25934 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes