Skip to content

src: fix return type in Hash#25936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengjiawen wants to merge 1 commit into from
Closed

src: fix return type in Hash #25936

gengjiawen wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawengengjiawen commented Feb 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 5, 2019
addaleax
addaleax reviewed Feb 5, 2019
View reviewed changes
@gengjiawengengjiawenforce-pushed the fix_type_in_Hash branch 2 times, most recently from 00f859a to f37d729CompareFebruary 5, 2019 02:42
@danbev
Copy link
Contributor

danbev commented Feb 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20658/

@addaleax
Copy link
Member

addaleax commented Feb 9, 2019

Landed in ea2350b

@addaleaxaddaleax closed this Feb 9, 2019
addaleax pushed a commit that referenced this pull request Feb 9, 2019
@gengjiawen@addaleax
src: fix return type in Hash
ea2350b
PR-URL: #25936 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Feb 10, 2019
@gengjiawen@targos
src: fix return type in Hash
85d5f67
PR-URL: #25936 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gengjiawen@danbev@addaleax@bnoordhuis@jasnell@cjihrig@nodejs-github-bot