report: make more items programmatically accessible#26019
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prefer structured output over stringified information for libuv handles and the native stack trace.
nodejs-github-bot added the c++ 
richardlau approved these changes Feb 9, 2019
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/20700/ (:heavy_check_mark:) |
cjihrig approved these changes Feb 10, 2019
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM. Side note - keeping the example report in the docs up to date is becoming a bit of a pain 😄
devsnek approved these changes Feb 10, 2019
jasnell approved these changes Feb 11, 2019
MemberAuthor
addaleax commented Feb 11, 2019
Landed in 2c84f6e |
addaleax added a commit that referenced this pull request Feb 11, 2019
Prefer structured output over stringified information for libuv handles and the native stack trace. PR-URL: #26019 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Feb 13, 2019
Prefer structured output over stringified information for libuv handles and the native stack trace. PR-URL: #26019 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer structured output over stringified information
for libuv handles and the native stack trace.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes