Fix icutrim build failure when building small-icu on Big-Endian platforms#2602
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fishrock123 added build 
Member
srl295 commented Sep 2, 2015
1135ad0 LGTM. |
Member
mhdawson commented Sep 16, 2015
Member
mhdawson commented Sep 17, 2015
CI run is good, will land. |
mhdawson pushed a commit that referenced this pull request Sep 17, 2015
Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. Fixes: #2601 PR-URL: #2602 Reviewed-By: Steven Loomis <[email protected]>
Member
mhdawson commented Sep 17, 2015
landed as 1fa0cb8 |
Fishrock123 pushed a commit that referenced this pull request Sep 20, 2015
Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. Fixes: #2601 PR-URL: #2602 Reviewed-By: Steven Loomis <[email protected]>
Member
mhdawson commented Sep 29, 2015
Landed in v4.1.1 so closing |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. See #2601 for details of the specific error that shows.
Cc @srl295