src: use same parameter name in node_report.cc

[gengjiawen]

Fix clang-tidy issue, use same parameter name, see

node/src/node_report.cc

Line 233 in 9c86e74

TIME_TYPE* tm_struct){

Also found that function declaration is located in .cc file. Any special reason for this file ?

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[joyeecheung]

Also found that function declaration is located in .cc file. Any special reason for this file ?

All the methods in node_report.cc are forward-declared so that the definitions can be placed arbitrarily, though that's not a style we normally use in this code base and more of the style of the original npm module.

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/20773/

[addaleax]

Landed in 66942d7 :)