Skip to content

worker: switch to internal assert module#26091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

worker: switch to internal assert module #26091

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Feb 14, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2598/pipeline

@nodejs-github-botnodejs-github-bot added the worker Issues and PRs related to Worker support. label Feb 14, 2019
@Trott
Copy link
MemberAuthor

Trott commented Feb 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20774/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 14, 2019
@Trott
Copy link
MemberAuthor

Trott commented Feb 16, 2019

Landed in a8c3adf

@TrottTrott closed this Feb 16, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 16, 2019
@Trott
worker: switch to internal assert module
a8c3adf
PR-URL: nodejs#26091 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 16, 2019
@Trott@addaleax
worker: switch to internal assert module
add154e
PR-URL: #26091 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott@rvagg
worker: switch to internal assert module
6929871
PR-URL: #26091 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@TrottTrott deleted the worker-internal-assert branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@danbevdanbevdanbev approved these changes

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@nodejs-github-bot@danbev@jasnell@addaleax@benjamingr@lpinca@devsnek@BridgeAR