Skip to content

Conversation

@Trott
Copy link
Member

Wrap at 80 chars, eliminate ALL CAPS, remove excessive bold and/or italics, remove "note that"...

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Feb 15, 2019
@Trott
Copy link
MemberAuthor

(The individual commits might be easier to review than the whole thing at once. Whole thing at once probably isn't bad, though.)

@Trott
Copy link
MemberAuthor

@Trott
Copy link
MemberAuthor

@nodejs/documentation This could use some reviews.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
PR-URL: nodejs#26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
Remove all-caps from child_process.md. PR-URL: nodejs#26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
PR-URL: nodejs#26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2019
@Trott
Copy link
MemberAuthor

Landed in c7b6a22...921f448

@TrottTrott closed this Feb 18, 2019
addaleax pushed a commit that referenced this pull request Feb 19, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
Remove all-caps from child_process.md. PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Remove all-caps from child_process.md. PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #26141 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
@TrottTrott deleted the edit-child-process branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@jasnell@vsemozhetbyt