tracing: use ‘real’ atomics#26156
Closed
tracing: use ‘real’ atomics #26156
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use actual atomic operations instead of things that are named as if they were atomics, but aren’t. Refs: nodejs#26100
addaleax added the trace_events 
nodejs-github-bot added the c++ 
devsnek approved these changes Feb 16, 2019
Member
devsnek left a comment
devsnek left a comment There was a problem hiding this comment.
it was totally atomic already because... uh... they ran on computers made of atoms!
hashseed approved these changes Feb 17, 2019
cjihrig approved these changes Feb 17, 2019
MemberAuthor
addaleax commented Feb 17, 2019
jasnell approved these changes Feb 18, 2019
eugeneo approved these changes Feb 19, 2019
MemberAuthor
addaleax commented Feb 19, 2019
Landed in 1c71c0c |
addaleax added a commit that referenced this pull request Feb 19, 2019
Use actual atomic operations instead of things that are named as if they were atomics, but aren’t. Refs: #26100 PR-URL: #26156 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]>
addaleax added a commit that referenced this pull request Feb 21, 2019
Use actual atomic operations instead of things that are named as if they were atomics, but aren’t. Refs: #26100 PR-URL: #26156 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Use actual atomic operations instead of things that are named as if they were atomics, but aren’t. Refs: #26100 PR-URL: #26156 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use actual atomic operations instead of things that are
named as if they were atomics, but aren’t.
Refs: #26100
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes