src: remove process.binding('config').fipsForced#26178
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead use `require('internal/options').getOptionValue` to query to value of `--force-fips`.
nodejs-github-bot added c++ 
MemberAuthor
joyeecheung commented Feb 18, 2019
danbev approved these changes Feb 18, 2019
addaleax approved these changes Feb 18, 2019
richardlau approved these changes Feb 18, 2019
jasnell approved these changes Feb 18, 2019
MemberAuthor
joyeecheung commented Feb 20, 2019
Landed in 7fc6e62 |
joyeecheung added a commit that referenced this pull request Feb 20, 2019
Instead use `require('internal/options').getOptionValue` to query to value of `--force-fips`. PR-URL: #26178 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>addaleax pushed a commit that referenced this pull request Feb 21, 2019
Instead use `require('internal/options').getOptionValue` to query to value of `--force-fips`. PR-URL: #26178 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Instead use `require('internal/options').getOptionValue` to query to value of `--force-fips`. PR-URL: #26178 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead use
require('internal/options').getOptionValuetoquery to value of
--force-fips.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes