Skip to content

src: remove redundant cast in method AfterStringPath#26218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengjiawen wants to merge 1 commit into from
Closed

src: remove redundant cast in method AfterStringPath #26218

gengjiawen wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawengengjiawen commented Feb 20, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Feb 20, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Feb 20, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/20918/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@gengjiawengengjiawen mentioned this pull request Feb 28, 2019
Closed
2 tasks
@addaleax
Copy link
Member

addaleax commented Feb 28, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21072/

@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

Landed in 10de8d9

@addaleaxaddaleax closed this Mar 1, 2019
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen@addaleax
src: remove redundant cast in method AfterStringPath
10de8d9
PR-URL: #26218 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen@addaleax
src: remove redundant cast in method AfterStringPath
6f9ab5e
PR-URL: #26218 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gengjiawen@BridgeAR@addaleax@jasnell@nodejs-github-bot