worker: provide process.execArgv#26267
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 22, 2019
@addaleax sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot added c++ 
addaleax added process 
joyeecheung approved these changes Feb 23, 2019
Member
jasnell commented Feb 23, 2019
do docs need to be updated for the execArgv option on the Worker constructor? |
cjihrig approved these changes Feb 23, 2019
addaleaxforce-pushed the worker-exec-argv branch from 0381d5b to 1da935eCompare
MemberAuthor
addaleax commented Feb 28, 2019
@jasnell Yup, added a note for that in 1da935e. |
MemberAuthor
addaleax commented Mar 1, 2019
addaleax added the author ready 
BridgeAR reviewed Mar 1, 2019
Uh oh!
There was an error while loading. Please reload this page.
jasnell approved these changes Mar 1, 2019
MemberAuthor
addaleax commented Mar 1, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the `Worker` constructor, that option is used as its value; if not, the parent’s `process.execArgv` is inherited (since that also goes for the actual options in that case).
MemberAuthor
addaleax commented Mar 1, 2019
MemberAuthor
addaleax commented Mar 2, 2019
Landed in f65b4af |
addaleax added a commit that referenced this pull request Mar 2, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the `Worker` constructor, that option is used as its value; if not, the parent’s `process.execArgv` is inherited (since that also goes for the actual options in that case). PR-URL: #26267 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Mar 2, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the `Worker` constructor, that option is used as its value; if not, the parent’s `process.execArgv` is inherited (since that also goes for the actual options in that case). PR-URL: #26267 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide
process.execArgv. If anexecArgvoption is passed to theWorkerconstructor, that option is used as its value; if not,the parent’s
process.execArgvis inherited (since that also goesfor the actual options in that case).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes