src: remove unused macro in env.cc#26273
Closed
+0 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
richardlau approved these changes Feb 23, 2019
addaleax approved these changes Feb 23, 2019
BridgeAR approved these changes Feb 23, 2019
jasnell approved these changes Feb 23, 2019
cjihrig approved these changes Feb 23, 2019
tniessen approved these changes Feb 23, 2019
lpinca approved these changes Feb 23, 2019
MemberAuthor
gengjiawen commented Mar 2, 2019
@addaleax Can you trigger Jenkins ci for this pr ? Thanks. |
Member
addaleax commented Mar 2, 2019
addaleax added the author ready 
Contributor
antsmartian commented Mar 3, 2019
Landed in d16cfa4 🎉 🎉 Thanks @gengjiawen 👍 |
antsmartian pushed a commit that referenced this pull request Mar 3, 2019
PR-URL: #26273 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
PR-URL: #26273 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes