tools: update markdown linter#26281
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a prohibited string, favoring `End-of-Life` for consistency. Refs: nodejs#26251
Collaborator
nodejs-github-bot commented Feb 23, 2019
@Trott sadly an error occured when I tried to trigger a build :( |
MemberAuthor
Trott commented Feb 23, 2019
jasnell approved these changes Feb 23, 2019
refack approved these changes Feb 24, 2019
Trott added the author ready 
lpinca approved these changes Feb 24, 2019
richardlau approved these changes Feb 24, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 26, 2019
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a prohibited string, favoring `End-of-Life` for consistency. Refs: nodejs#26251 PR-URL: nodejs#26281 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Trott commented Feb 26, 2019
Landed in ccd6b12 |
addaleax pushed a commit that referenced this pull request Mar 1, 2019
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a prohibited string, favoring `End-of-Life` for consistency. Refs: #26251 PR-URL: #26281 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update remark-preset-lint-node to 1.4.0. This adds
End-Of-Lifeas aprohibited string, favoring
End-of-Lifefor consistency.Fair amount of diff-noise in this one because the big change is in an auto-generated file. Suppressing whitespace-only changes will probably help.
Refs: #26251
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes