test: improve validation of report output#26289
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 24, 2019
@cjihrig sadly an error occured when I tried to trigger a build :( |
addaleax approved these changes Feb 24, 2019
richardlau approved these changes Feb 24, 2019
Member
richardlau commented Feb 24, 2019
https://github.com/nodejs/node/pull/26140/files#diff-2309f7f663f8532063e90537b0ccf4c7 |
ContributorAuthor
cjihrig commented Feb 24, 2019
Even better! |
jasnell approved these changes Feb 25, 2019
cjihrigforce-pushed the report-validation branch 4 times, most recently from 773c707 to 7067d60Compare
This commit improves the validation of generated diagnostic reports. PR-URL: nodejs#26289 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
cjihrig commented Mar 2, 2019
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
This commit improves the validation of generated diagnostic reports. PR-URL: #26289 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the validation of generated diagnostic reports. This enforces the general report schema. Next steps include tighter validation of various libuv handle types, and checking for specific values (such as an error message or stack frame).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes