Skip to content

doc: correct typos in various docs#26312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BeniCheni wants to merge 2 commits into from
Closed

doc: correct typos in various docs #26312

BeniCheni wants to merge 2 commits into from

Conversation

@BeniCheni
Copy link
Contributor

@BeniCheniBeniCheni commented Feb 26, 2019

Noticed a few typos while reading docs. Tried out corrections in this PR.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 26, 2019
Trott
Trott reviewed Feb 26, 2019
View reviewed changes
@BeniCheni
Copy link
ContributorAuthor

BeniCheni commented Feb 26, 2019

A certificate can have multiple altnames. Can you put just this one back the way it was?

@Trott, reverted to "altnames". Thanks.

@Trott
Copy link
Member

Trott commented Feb 26, 2019•
edited
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2707/ ✅

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2019
@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

Landed in 8f87080

@addaleaxaddaleax closed this Mar 2, 2019
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@BeniCheni@addaleax
doc: correct typos in various docs
8f87080
PR-URL: #26312 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@BeniCheni@addaleax
doc: correct typos in various docs
bc5771e
PR-URL: #26312 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@BeniCheniBeniCheni deleted the doc-typos-correction branch March 2, 2019 13:36
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BeniCheni@Trott@addaleax@jasnell@lpinca@cjihrig@BethGriggs@nodejs-github-bot