Skip to content

doc: add missing https Agent maxCachedSessions#26433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-moteau wants to merge 1 commit into from
Closed

doc: add missing https Agent maxCachedSessions #26433

nicolas-moteau wants to merge 1 commit into from

Conversation

@nicolas-moteau
Copy link
Contributor

@nicolas-moteaunicolas-moteau commented Mar 4, 2019

Refs: #2228
Refs: #4252

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem. labels Mar 4, 2019
@BridgeARBridgeAR requested review from lpinca and mcollinaMarch 5, 2019 23:26
lpinca
lpinca approved these changes Mar 6, 2019
View reviewed changes
@nicolas-moteau
Copy link
ContributorAuthor

nicolas-moteau commented Mar 6, 2019

@lpinca, thanks for the the remarks. I made the modifications.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2783/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@nicolas-moteau@BridgeAR
doc: add missing https Agent maxCachedSessions
d50fc51
PR-URL: nodejs#26433 Refs: nodejs#2228 Refs: nodejs#4252 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in d50fc51 🎉

@BridgeARBridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@nicolas-moteau@BridgeAR
doc: add missing https Agent maxCachedSessions
4b1c1dc
PR-URL: nodejs#26433 Refs: nodejs#2228 Refs: nodejs#4252 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@nicolas-moteau@BridgeAR
doc: add missing https Agent maxCachedSessions
6cc559f
PR-URL: #26433 Refs: #2228 Refs: #4252 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@mcollinamcollinaAwaiting requested review from mcollina

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpsIssues or PRs related to the https subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-moteau@BridgeAR@lpinca@nodejs-github-bot