[v6.x backport] build: set -blibpath: for AIX#26478
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
richardlauforce-pushed the restore-aix-blibpath-6 branch from 0e3e404 to d40535bCompare
MemberAuthor
richardlau commented Mar 6, 2019
See nodejs/Release#414 (comment). #25447 doesn't cherry-pick cleanly to |
richardlau added aix 
MemberAuthor
richardlau commented Mar 7, 2019
MemberAuthor
richardlau commented Mar 7, 2019
Windows failures look like infra: nodejs/build#1716 |
nodejs#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: nodejs#25444 Backport-PR-URL: nodejs#26478 PR-URL: nodejs#25447 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlauforce-pushed the restore-aix-blibpath-6 branch from d40535b to 7b34f81CompareMemberAuthor
richardlau commented Mar 12, 2019
Rebased onto current New CI: https://ci.nodejs.org/job/node-test-pull-request/21470/ |
BethGriggs approved these changes Mar 15, 2019
BethGriggs pushed a commit that referenced this pull request Mar 15, 2019
#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 Backport-PR-URL: #26478 PR-URL: #25447 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
BethGriggs commented Mar 15, 2019
Landed on |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17604 refactored the gyp files
so that
-blibpath:on AIX was only set ifnode_shared=="true".Restore the setting for non-shared builds.
Fixes: #25444
PR-URL: #25447
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Michael Dawson [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes