Skip to content

test,doc: add inspector API example for heapdump#26498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sam-github wants to merge 1 commit into from
Closed

test,doc: add inspector API example for heapdump #26498

sam-github wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Contributor

@sam-githubsam-github commented Mar 7, 2019•
edited
Loading

cf. nodejs/diagnostics#279

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 7, 2019

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2801/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Mar 7, 2019
@sam-github
Copy link
ContributorAuthor

sam-github commented Mar 7, 2019

ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2803/

@eugeneo
Copy link
Contributor

eugeneo commented Mar 7, 2019

Would you consider adding a test case that serves as an example but also ensures this documentation is kept in sync with the code changes in the future?

@eugeneoeugeneo closed this Mar 7, 2019
@eugeneoeugeneo reopened this Mar 7, 2019
@sam-github
Copy link
ContributorAuthor

sam-github commented Mar 7, 2019 via email

cjihrig
cjihrig approved these changes Mar 7, 2019
View reviewed changes
eugeneo
eugeneo approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@eugeneoeugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

addaleax
addaleax reviewed Mar 7, 2019
View reviewed changes
addaleax
addaleax approved these changes Mar 7, 2019
View reviewed changes
@jasnelljasnell mentioned this pull request Mar 7, 2019
Closed
4 tasks
@BridgeARBridgeAR changed the title doc: add inspector API example for heapdumptest,doc: add inspector API example for heapdumpMar 8, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21330/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@sam-githubsam-githubforce-pushed the doc-heapdump-example branch from 3a31f6d to c75c84dCompareMarch 8, 2019 22:52
@sam-github
Copy link
ContributorAuthor

sam-github commented Mar 8, 2019

ci: https://ci.nodejs.org/job/node-test-pull-request/21352/

@sam-githubsam-githubforce-pushed the doc-heapdump-example branch from c75c84d to 02691ceCompareMarch 8, 2019 23:49
@sam-github
Copy link
ContributorAuthor

sam-github commented Mar 8, 2019

ci: https://ci.nodejs.org/job/node-test-pull-request/21361/

@danbev
Copy link
Contributor

danbev commented Mar 11, 2019

Landed in a445244.

@danbevdanbev closed this Mar 11, 2019
danbev pushed a commit that referenced this pull request Mar 11, 2019
@sam-github@danbev
doc: add inspector API example for heapdump
a445244
PR-URL: #26498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@sam-github@BridgeAR
doc: add inspector API example for heapdump
4a72eb3
PR-URL: #26498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@sam-github@BridgeAR
doc: add inspector API example for heapdump
5ad9929
PR-URL: #26498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@sam-githubsam-github deleted the doc-heapdump-example branch March 20, 2019 15:06
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@sam-github@BethGriggs
doc: add inspector API example for heapdump
d4a1d79
PR-URL: #26498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@fanatidfanatid mentioned this pull request Sep 26, 2019
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+1 more reviewer

@eugeneoeugeneoeugeneo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sam-github@nodejs-github-bot@eugeneo@BridgeAR@danbev@jasnell@addaleax@lpinca@cjihrig@richardlau