dns: remove dns.promises experimental warning#26592

cjihrig · 2019-03-11T16:52:56Z

In a similar spirit to #26581.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2019-03-11T16:52:58Z

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2864/pipeline

devsnek · 2019-03-11T17:08:04Z

i have a similar concern here.

as long as x.promises existing doesn't block x/promises from existing this is probably fine.

Trott · 2019-03-11T19:10:30Z

Same question as in the other PR: This leaves it as experimental in the docs. That's intentional? (I'd prefer we make it stable in the docs and label this semver-major but that's just me!)

jasnell · 2019-03-11T19:56:07Z

Perhaps it's time just to take it out of experimental?

targos · 2019-03-11T19:58:37Z

Did we get feedback or reported usage ?

addaleax

Like @jdalton suggested in the other PR, it probably makes sense to make this enumerable as well

BridgeAR · 2019-03-25T18:06:30Z

Ping @cjihrig

cjihrig · 2019-03-27T17:26:53Z

as long as x.promises existing doesn't block x/promises from existing this is probably fine.

It shouldn't block it.

This leaves it as experimental in the docs.

I've add a semver major commit to address it.

Perhaps it's time just to take it out of experimental?

Agreed. It's been ~9 months with no significant issues.

Did we get feedback or reported usage ?

Not that I'm aware of.

it probably makes sense to make this enumerable as well

Done.

nodejs-github-bot · 2019-03-27T17:27:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21967/

EDIT(cjihrig): CI was yellow.

cjihrig · 2019-03-29T12:43:30Z

This requires @nodejs/tsc review because it's semver major. (@addaleax you may want to re-review).

mcollina

LGTM

PR-URL: nodejs#26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

cjihrig · 2019-03-29T22:58:16Z

Landed in 415a825...d8c2803. Thanks for the reviews.

addaleax · 2019-04-02T12:15:42Z

@cjihrig Sorry, I missed that you had labelled this semver-major. Is there any particular reason? I’d prefer to remove the label.

cjihrig · 2019-04-02T12:44:02Z

@addaleax because of the change in enumerability. I was being overly cautious, and would also be fine dropping the label.

PR-URL: #26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163

Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163

PR-URL: #26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Notable changes: - **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts) [#29921](#29921) - **dns**: remove dns.promises experimental warning (cjihrig) [#26592](#26592) - **fs**: remove experimental warning for fs.promises (Anna Henningsen) [#26581](#26581) - **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof) [#29401](#29401) - **stream**: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) PR-URL: #29875

Notable changes: - **deps**: update npm to 6.11.3 (claudiahdz) [#29430](#29430) - **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts) [#29921](#29921) - **dns**: remove dns.promises experimental warning (cjihrig) [#26592](#26592) - **fs**: remove experimental warning for fs.promises (Anna Henningsen) [#26581](#26581) - **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof) [#29401](#29401) - **stream**: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) PR-URL: #29875

Notable changes: * crypto: * add support for chacha20-poly1305 for AEAD (chux0519) #24081 * increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799 * deps: * update npm to 6.11.3 (claudiahdz) #29430 * upgrade openssl sources to 1.1.1d (Sam Roberts) #29921 * dns: * remove dns.promises experimental warning (cjihrig) #26592 * fs: * remove experimental warning for fs.promises (Anna Henningsen) #26581 * http: * makes response.writeHead return the response (Mark S. Everitt) #25974 * http2: * makes response.writeHead return the response (Mark S. Everitt) #25974 * n-api: * make func argument of napi\_create\_threadsafe\_function optional (legendecas) #27791 * mark version 5 N-APIs as stable (Gabriel Schulhof) #29401 * implement date object (Jarrod Connolly) #25917 * process: * add --unhandled-rejections flag (Ruben Bridgewater) #26599 * stream: * implement Readable.from async iterator utility (Guy Bedford) #27660 * make Symbol.asyncIterator support stable (Matteo Collina) #26989 PR-URL: #29875

nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Mar 11, 2019

vsemozhetbyt mentioned this pull request Mar 11, 2019
Preparation for Node.js 12 nodejs/Release#417
Closed
6 tasks

addaleax approved these changes Mar 12, 2019
View reviewed changes

cjihrig force-pushed the dns-promises branch from 88895d7 to 3b898b5Compare March 27, 2019 17:24

cjihrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 28, 2019

jasnell approved these changes Mar 29, 2019
View reviewed changes

mcollina approved these changes Mar 29, 2019
View reviewed changes

targos approved these changes Mar 29, 2019
View reviewed changes

cjihrig added 3 commits March 29, 2019 18:57

dns: remove dns.promises experimental warning
aa2ac19
PR-URL: nodejs#26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

dns: make dns.promises enumerable
61e4d89
PR-URL: nodejs#26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

doc: move dns.promises to stable status
d8c2803
PR-URL: nodejs#26592 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

cjihrig force-pushed the dns-promises branch from 3b898b5 to d8c2803Compare March 29, 2019 22:57

cjihrig closed this Mar 29, 2019

cjihrig deleted the dns-promises branch March 29, 2019 22:58

cjihrig merged commit d8c2803 into nodejs:masterMar 29, 2019

addaleax mentioned this pull request Mar 30, 2019
fs: remove experimental warning for fs.promises #26581
Closed
2 tasks

BethGriggs mentioned this pull request Apr 2, 2019
Node.js 12 SemVer Major Cut-off #26844
Closed

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 2, 2019

addaleax removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 2, 2019

BethGriggs mentioned this pull request Apr 9, 2019
v11.14.0 proposal #27163
Merged

BethGriggs added the lts-watch-v10.x label Aug 20, 2019

BethGriggs added the backport-requested-v10.x label Oct 16, 2019

BethGriggs added land-on-v10.x and removed backport-requested-v10.x labels Oct 18, 2019

BethGriggs mentioned this pull request Oct 18, 2019
v10.17.0 proposal #29875
Merged

Uh oh!

dns: remove dns.promises experimental warning#26592

dns: remove dns.promises experimental warning #26592

Uh oh!

Conversation

cjihrig commented Mar 11, 2019

Checklist

Uh oh!

nodejs-github-bot commented Mar 11, 2019

Uh oh!

devsnek commented Mar 11, 2019

Uh oh!

Trott commented Mar 11, 2019

Uh oh!

jasnell commented Mar 11, 2019

Uh oh!

targos commented Mar 11, 2019

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Mar 25, 2019

Uh oh!

cjihrig commented Mar 27, 2019

Uh oh!

nodejs-github-bot commented Mar 27, 2019• edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig commented Mar 29, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Mar 29, 2019

Uh oh!

addaleax commented Apr 2, 2019

Uh oh!

cjihrig commented Apr 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nodejs-github-bot commented Mar 27, 2019•
edited by cjihrig
Loading