doc: edit "Technical How-To" section of guide#26601
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
richardlau approved these changes Mar 12, 2019
Member
richardlau commented Mar 12, 2019
|
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct.
MemberAuthor
Trott commented Mar 12, 2019
Typo in commit message fixed. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2876/ |
Trott added the author ready 
BethGriggs approved these changes Mar 12, 2019
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Trott <[email protected]>
MemberAuthor
Trott commented Mar 12, 2019
vsemozhetbyt added the meta Trott added a commit to Trott/io.js that referenced this pull request Mar 14, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: nodejs#26601 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
MemberAuthor
Trott commented Mar 14, 2019
Landed in 107c95d |
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: nodejs#26601 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: #26601 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: #26601 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
This was referenced May 29, 2019
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes