tools: replace GYP with GYP3#26620

refack · 2019-03-12T21:56:19Z

Replace the abandoned GYP with GYP3, which has the following benefits:

Is Python2x3 compatible.
Active development.
Lives in GitHub - https://github.com/refack/GYP.
Has CI testing - https://travis-ci.com/refack/GYP/
Follows semver versioning - current version (6.0.0) is backwards compatible with GYP.
Has an active roadmap.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-03-12T21:56:21Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2887/pipeline

Trott · 2019-03-12T22:53:35Z

(If possible to change now that it's opened, maybe make this a draft pull request?)

refack · 2019-03-12T23:45:33Z

(If possible to change now that it's opened, maybe make this a draft pull request?)

I was looking for how to do that... Only found it after reading the docs.

Anyway, this should be working now, and it's ready for Rubber Stamp reviews.
~~https://ci.nodejs.org/job/node-test-pull-request/21487/~~
https://ci.nodejs.org/job/node-test-commit/26674/
(I might patch GYP3 a bit more)

richardlau · 2019-03-14T02:42:22Z

* Lives in GitHub - https://github.com/refack/GYP.

Whatever happened to the plan to transfer into this org? nodejs/admin#247

refack · 2019-03-14T03:28:07Z

Whatever happened to the plan to transfer into this org? nodejs/admin#247

That has been shelved for various $REASONS.

targos · 2019-03-14T19:09:01Z

There are unrelated changes in the LICENSE file

refack · 2019-03-14T19:11:10Z

There are unrelated changes in the LICENSE file

That's what I got from re-generating 🤷‍♂️

BTW: for easy review, first commit is pure GYP vendoring. Second (ATM 2b6fd3f) is just changes in node file.

ryzokuken

Major +1.

targos · 2019-03-16T19:15:01Z

That's what I got from re-generating 🤷‍♂️

I can't reproduce. If I run ./tools/license-builder.sh on master, LICENSE is unchanged.

LICENSE

refack · 2019-03-16T19:31:42Z

That's what I got from re-generating 🤷‍♂️
I can't reproduce. If I run ./tools/license-builder.sh on master, LICENSE is unchanged.

Issue resolved. LICENSE regenerated.

targos

Rubber stamp

gengjiawen · 2019-04-16T15:28:02Z

@refack Need rebase.

refack · 2019-04-16T15:57:05Z

Anyone want to help me figure out what I broke WRT cross-compilation? refack/GYP3@bd11dd1...d1f1343

richard-townsend-arm · 2019-04-24T11:33:32Z

AIX builds seem to have the following error in their logs (e.g. https://ci.nodejs.org/job/node-test-commit-aix/22631/nodes=aix61-ppc64/console)
17:13:57 ccache: error: Could not find compiler "cc" in PATH

richard-townsend-arm · 2019-04-24T11:35:35Z

ARMv7 builds seem to fail with this error:

../deps/v8/src/arm/assembler-arm.cc:177:2: error: #error "CAN_USE_ARMV7_INSTRUCTIONS should match CAN_USE_VFP3_INSTRUCTIONS" #error "CAN_USE_ARMV7_INSTRUCTIONS should match CAN_USE_VFP3_INSTRUCTIONS
(https://ci.nodejs.org/job/node-cross-compile/23120/nodes=cross-compiler-armv7-gcc-4.9.4/console)

Refs: https://github.com/refack/GYP/tree/6.0.3

nodejs-github-bot · 2019-05-30T23:16:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23503/

See nodejs/node#26620 and bincrafters/community#851 for further reasoning

Croydon · 2019-07-02T16:19:23Z

What is the status of this?

sam-github · 2019-08-14T23:24:43Z

FWIW, sam-github@c70af5c is another vendoring attempt I made that duplicates this, except its done against current master.

cclauss · 2019-11-01T08:15:55Z

While I was a huge fan of this PR back in the day, I now believe that we can close it. Is there anything that we need to carry forward?

sam-github · 2019-11-01T16:31:57Z

Closing because it isn't active, but not because it isn't worthwhile if anyone wants to take it up again.

nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 12, 2019

refack self-assigned this Mar 12, 2019

refack added wip Issues and PRs that are still a work in progress. gyp Issues and PRs related to the GYP tool and .gyp build files labels Mar 12, 2019

refack added this to the 12.0.0 milestone Mar 12, 2019

This comment has been minimized.
Sign in to view

refack changed the title ~~[WIP]tools: replace GYP with GYP3~~tools: replace GYP with GYP3Mar 12, 2019

refack removed the wip Issues and PRs that are still a work in progress. label Mar 12, 2019

refack force-pushed the bump-gyp3-86ab71caad branch from e918e3f to 2b6fd3fCompare March 12, 2019 23:57

refack mentioned this pull request Mar 13, 2019
gyp, win: teach MSVS generator about MARMASM Items #26020
Closed
3 tasks

This was referenced Mar 14, 2019
Support ARM64 Windows desktop #25998
Closed
configure: Enable ARM64 single-toolchain build on Windows nodejs/node-gyp#1678
Closed

refack added the python PRs and issues that require attention from people who are familiar with Python. label Mar 15, 2019

cclauss mentioned this pull request Mar 15, 2019
build: ongoing list of actions for Python 3 compatibility #25789
Closed
63 tasks

ryzokuken approved these changes Mar 16, 2019
View reviewed changes

richardlau reviewed Mar 16, 2019
View reviewed changes

LICENSE Outdated Show resolvedHide resolved

refack force-pushed the bump-gyp3-86ab71caad branch from 2b6fd3f to 49a1c5fCompare March 16, 2019 19:30

This comment has been minimized.
Sign in to view

targos approved these changes Mar 16, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

refack mentioned this pull request Apr 13, 2019
Building Node.js on Visual Studio 2019 #27214
Closed

refack force-pushed the bump-gyp3-86ab71caad branch from 73fd43c to a669e35Compare April 16, 2019 16:07

This comment has been minimized.
Sign in to view

refack mentioned this pull request Apr 24, 2019
job request: CI testing for GYP3 nodejs/build#1789
Closed

Trott removed this from the 12.0.0 milestone Apr 29, 2019

refack mentioned this pull request May 2, 2019
tools,build: use the python interpreter running gyp througout the whole build process #27476
Closed
1 task

refack added 2 commits May 30, 2019 19:14

tools: replace GYP with GYP3 v6.0.3 (1/2)
b12a56e
Refs: https://github.com/refack/GYP/tree/6.0.3

tools: replace GYP with GYP3 (2/2) - node changes
aec2150

refack force-pushed the bump-gyp3-86ab71caad branch from a669e35 to aec2150Compare May 30, 2019 23:15

fixup! keep output dir on Windows
28b14ec

cclauss mentioned this pull request Jun 5, 2019
Support for Python 3 nodejs/node-gyp#1337
Closed

sinloss mentioned this pull request Jun 27, 2019
The GYP issue: where, how and who to maintain nodejs/node-gyp#1791
Closed

Croydon mentioned this pull request Jul 2, 2019
[gyp_installer] Usage of GYP's Command Expansions leads to an AttributeError exception bincrafters/community#851
Closed

Croydon added a commit to bincrafters/conan-gyp_installer that referenced this pull request Jul 2, 2019
Change to Refack's GYP fork
832fa65
See nodejs/node#26620 and bincrafters/community#851 for further reasoning

sam-github mentioned this pull request Aug 14, 2019
Re-vendor node/node-gyp --> tools/gyp/ #28555
Closed

richardlau mentioned this pull request Aug 14, 2019
build: find Python 3 or Python 2 in configure #25878
Closed
4 tasks

Trott force-pushed the master branch from 1ecc406 to 49cf67eCompare September 17, 2019 16:51

cclauss mentioned this pull request Sep 20, 2019
build: test Python 3.7 on Travis CI #29451
Closed
3 tasks

sam-github closed this Nov 1, 2019

Uh oh!

tools: replace GYP with GYP3#26620

tools: replace GYP with GYP3 #26620

Uh oh!

Conversation

refack commented Mar 12, 2019• edited by sam-github Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Mar 12, 2019

Uh oh!

This comment has been minimized.

Trott commented Mar 12, 2019

Uh oh!

refack commented Mar 12, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Mar 14, 2019

Uh oh!

refack commented Mar 14, 2019

Uh oh!

targos commented Mar 14, 2019

Uh oh!

refack commented Mar 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryzokuken left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Mar 16, 2019

Uh oh!

Uh oh!

refack commented Mar 16, 2019

Uh oh!

This comment has been minimized.

targos left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

gengjiawen commented Apr 16, 2019

Uh oh!

refack commented Apr 16, 2019

Uh oh!

This comment has been minimized.

richard-townsend-arm commented Apr 24, 2019

Uh oh!

richard-townsend-arm commented Apr 24, 2019

Uh oh!

nodejs-github-bot commented May 30, 2019

Uh oh!

Croydon commented Jul 2, 2019

Uh oh!

sam-github commented Aug 14, 2019

Uh oh!

cclauss commented Nov 1, 2019

Uh oh!

sam-github commented Nov 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

refack commented Mar 12, 2019•
edited by sam-github
Loading

refack commented Mar 12, 2019•
edited
Loading

refack commented Mar 14, 2019•
edited
Loading