src: fix warning in node_messaging

[ZYSzys]

Got some warning when building Node.js from newest master.

So fixed by:

• Use WasmModuleObject instead of WasmCompiledModule.
• Use IsDetachable() instead of IsNeuterable.
• Use Detach() instead of Neuter.

In file included from /Users/zyszys/Projects/node/out/Release/obj/gen/node_javascript.cc:3: In file included from ../src/node_internals.h:27: In file included from ../src/env-inl.h:35: In file included from ../src/node_worker.h:7: ../src/node_messaging.h:52:48: warning: 'WasmCompiledModule' is deprecated: Use WasmModuleObject [-Wdeprecated-declarations] uint32_t AddWASMModule(v8::WasmCompiledModule::TransferrableModule&& mod); ^ ../deps/v8/include/v8.h:4444:1: note: 'WasmCompiledModule' has been explicitly marked deprecated here V8_DEPRECATED("Use WasmModuleObject", ^ ../deps/v8/include/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED' declarator __attribute__((deprecated(message))) ^ In file included from /Users/zyszys/Projects/node/out/Release/obj/gen/node_javascript.cc:3: In file included from ../src/node_internals.h:27: In file included from ../src/env-inl.h:35: In file included from ../src/node_worker.h:7: ../src/node_messaging.h:71:37: warning: 'WasmCompiledModule' is deprecated: Use WasmModuleObject [-Wdeprecated-declarations] std::vector<v8::WasmCompiledModule::TransferrableModule> wasm_modules_; ^ ../deps/v8/include/v8.h:4444:1: note: 'WasmCompiledModule' has been explicitly marked deprecated here V8_DEPRECATED("Use WasmModuleObject", ^ ../deps/v8/include/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED' declarator __attribute__((deprecated(message))) ^ 2 warnings generated.

../src/node_messaging.cc:73:14: warning: 'WasmCompiledModule' is deprecated: Use WasmModuleObject [-Wdeprecated-declarations] MaybeLocal<WasmCompiledModule> GetWasmModuleFromId( ^ ../deps/v8/include/v8.h:4444:1: note: 'WasmCompiledModule' has been explicitly marked deprecated here V8_DEPRECATED("Use WasmModuleObject", ^ ../deps/v8/include/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED' declarator __attribute__((deprecated(message))) ^ ../src/node_messaging.cc:238:31: warning: 'WasmCompiledModule' is deprecated: Use WasmModuleObject [-Wdeprecated-declarations] Isolate* isolate, Local<WasmCompiledModule> module) override{^ ../deps/v8/include/v8.h:4444:1: note: 'WasmCompiledModule' has been explicitly marked deprecated here V8_DEPRECATED("Use WasmModuleObject", ^ ../deps/v8/include/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED' declarator __attribute__((deprecated(message))) ^ ../src/node_messaging.cc:305:18: warning: 'IsNeuterable' is deprecated: Use IsDetachable() instead. [-Wdeprecated-declarations] if (!ab->IsNeuterable() ||ab->IsExternal() || ^ ../deps/v8/include/v8.h:4723:3: note: 'IsNeuterable' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use IsDetachable() instead.", ^ ../deps/v8/include/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ ../src/node_messaging.cc:371:9: warning: 'Neuter' is deprecated: Use Detach() instead. [-Wdeprecated-declarations] ab->Neuter(); ^ ../deps/v8/include/v8.h:4737:3: note: 'Neuter' has been explicitly marked deprecated here V8_DEPRECATE_SOON("Use Detach() instead.", inline void Neuter()){Detach()} ^ ../deps/v8/include/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message)))

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[addaleax]

I’d be okay with fast-tracking this. (:+1: this comment if you agree.)

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/21563/

[mhdawson]

LGTM

[addaleax]

Landed in 0752a18