test: fix test-heapdump-worker#26713
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This test was broken by d35af56. Refs: nodejs#21283Fixes: nodejs#26712
addaleax added worker 
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/21608/ Please 👍 this comment to approve fast-tracking, it unbreaks a test. |
richardlau approved these changes Mar 17, 2019
gireeshpunathil approved these changes Mar 17, 2019
cjihrig approved these changes Mar 18, 2019
Member
richardlau commented Mar 18, 2019
Landed in ed60e86. |
richardlau pushed a commit that referenced this pull request Mar 18, 2019
This test was broken by d35af56. Refs: #21283Fixes: #26712 PR-URL: #26713 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
This test was broken by d35af56. Refs: nodejs#21283Fixes: nodejs#26712 PR-URL: nodejs#26713 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
This test was broken by d35af56. Refs: #21283Fixes: #26712 PR-URL: #26713 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was broken by d35af56.
Refs: #21283
Fixes: #26712
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes