test: optimize test-http2-large-file#26737
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Optimize test-http2-large-file so it only allocates a single buffer.
MemberAuthor
Trott commented Mar 18, 2019
MemberAuthor
Trott commented Mar 18, 2019
Again, I don't expect this to fix the test flakiness, but hey, let's check, and let's at least make sure it doesn't make things obviously worse.... Stress test on master using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2165/nodes=win2008r2-vs2017/ Stress test on this PR using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2166/ (The test failures in #22327 only seem to happen on Rackspace + Win 2008 R2, at least recently.) |
MemberAuthor
Trott commented Mar 19, 2019
Sorry to ping but I was hoping to get a review or two by now? @nodejs/http2 @nodejs/testing |
ZYSzys approved these changes Mar 19, 2019
Trott added the author ready 
MemberAuthor
Landed in ba1c5ff. |
Trott added a commit to Trott/io.js that referenced this pull request Mar 20, 2019
Optimize test-http2-large-file so it only allocates a single buffer. PR-URL: nodejs#26737 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Optimize test-http2-large-file so it only allocates a single buffer. PR-URL: nodejs#26737 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Optimize test-http2-large-file so it only allocates a single buffer. PR-URL: #26737 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
Optimize test-http2-large-file so it only allocates a single buffer. PR-URL: #26737 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Optimize test-http2-large-file so it only allocates a single buffer. PR-URL: #26737 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
This was referenced May 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize test-http2-large-file so it only allocates a single buffer.
I don't expect that this will resolve#22327, but one small change at a time....
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes