Skip to content

Conversation

@refack
Copy link
Contributor

'cause usually you simply want the job done...
Refs: #26252

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@refackrefack added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 18, 2019
@refackrefack added this to the 12.0.0 milestone Mar 18, 2019
@refackrefack self-assigned this Mar 18, 2019
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 18, 2019
@refackrefack requested review from BridgeAR and danbevMarch 18, 2019 14:50
@refack
Copy link
ContributorAuthor

/CC @nodejs/build @nodejs/build-files

Semver-Major since downstream embedders (and our CI) depend on make's output.

@refackrefack added the meta Issues and PRs related to the general management of the project. label Mar 18, 2019
@rvagg
Copy link
Member

previous discussion, you might want to check with people involved in that: #10403

Copy link
Member

@rvaggrvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I don't see this as semver-major, I'm not aware of anyone that relies on compiler output in a breaking way. In our CI we could just run make with V=1 everywhere if folks were concerned enough to see the output (I'm not, I like having less output, it makes Jenkins more manageable!).

@refack
Copy link
ContributorAuthor

/PING @trevnorris@bnoordhuis@addaleax@gibfahn

BTW: The pretty format comes from GYP

quiet_cmd_cc = CC($(TOOLSET)) $@
cmd_cc = $(CC.$(TOOLSET)) -o $@ $< $(GYP_CFLAGS) $(DEPFLAGS) $(CFLAGS.$(TOOLSET)) -c
quiet_cmd_cxx = CXX($(TOOLSET)) $@
cmd_cxx = $(CXX.$(TOOLSET)) -o $@ $< $(GYP_CXXFLAGS) $(DEPFLAGS) $(CXXFLAGS.$(TOOLSET)) -c

So that could be easily be manipulated as well.

AS for Jenkins, my dream is nodejs/build#1517

@refack
Copy link
ContributorAuthor

fwiw I don't see this as semver-major, I'm not aware of anyone that relies on compiler output in a breaking way.

We've had complaints before 🤷‍♂️

@BridgeAR
Copy link
Member

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@BridgeAR
Copy link
Member

PR-URL: nodejs#26740 Refs: nodejs#26252 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.metaIssues and PRs related to the general management of the project.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@rvagg@BridgeAR@danbev@nodejs-github-bot