Add tests for PKCS#8 private keys#26898
Uh oh!
There was an error while loading. Please reload this page.
Conversation
sasurau4 changed the title 
sasurau4force-pushed the add-tests-for-pkcs8-private-keys branch from 66f3032 to 57fd106Compare
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM, thanks for picking this up!
test/parallel/test-crypto-rsa-dsa.js Outdated
| assert.strictEqual(verify.verify(dsaPubPem,signature,'hex'),true); | ||
| // Test the legacy 'DSS1' name. |
There was a problem hiding this comment.
I'd be okay with dropping this, that's already checked around line 250.
There was a problem hiding this comment.
In my curious, is DSS1 same as SHA-1? 🤔
I found following line in Node.js Project but I couldn't find what happened historically about the relationship between DSS1 and SHA-1 from Google search.
Line 4459 in b4f58c2
There was a problem hiding this comment.
DSS1 stands for DSA (Digital Signature Algorithm) with SHA-1 as the hash function. It's a long-deprecated (and now removed) openssl synonym from when openssl conflated public key algorithms with their hash functions.
BridgeAR commented Mar 25, 2019
@sasurau4 the problem about the test suite can be circumvented by running the tests directly with: |
BridgeAR added the author ready 
nodejs-github-bot commented Mar 25, 2019
sasurau4 commented Mar 26, 2019
@BridgeAR The tests succeeded when I ran |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sasurau4 commented Mar 26, 2019
@tniessen I fixed pointed out. Thanks for your review 👍 |
nodejs-github-bot commented Mar 27, 2019
tniessen changed the title 
danbev commented Mar 28, 2019
Landed in 85546c2. |
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
9 participants
I added tests for unencrypted PKCS#8 private keys.
I generated the test PKCS#8 private keys by converting
test_rsa_privkey,pemandtest_dsa_privkey.pembyopensslcommand.Refs: #24928
I ranmake -j4 testcommand, but failed.detailed error log
My environment is Ubuntu 18.04.2 LTS and succeeded when I ranmake test-onlycommand.Please help me🙏Updated: solved the above problem.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes