util: add subclass and null prototype support for errors in inspect#26923
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive.
nodejs-github-bot added the util 
jasnell approved these changes Mar 26, 2019
Collaborator
nodejs-github-bot commented Mar 26, 2019
BridgeAR added the author ready 
targos approved these changes Mar 29, 2019
MemberAuthor
BridgeAR commented Mar 29, 2019
@targos@jasnell do you have an opinion about the semverness of this PR? CITGM master https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1782/ |
Member
jasnell commented Mar 29, 2019
No opinion on it really. I trust your judgement on it |
Member
targos commented Mar 29, 2019
Same |
Member
targos commented Mar 30, 2019
Landed in e54f237 |
targos pushed a commit that referenced this pull request Mar 30, 2019
This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive. PR-URL: #26923 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MemberAuthor
BridgeAR commented Mar 30, 2019
I added the do not land labels on this for v6-v10. |
4 tasks
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive. PR-URL: #26923 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive. PR-URL: #26923 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.
We normally handle changed
util.inspect()output as semver-patchbut in this case I'd say it's more like a semver-major even though I'd
love to get some early feedback. Any opinions about this?
CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1778/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes