Skip to content

doc: add information about modules cache behavior#26971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BridgeAR wants to merge 3 commits into from
Closed

doc: add information about modules cache behavior #26971

BridgeAR wants to merge 3 commits into from

Conversation

@BridgeAR
Copy link
Member

@BridgeARBridgeAR commented Mar 28, 2019

This publicly documents that adding native module names will resolve
the added entry instead of the native module.

It also updates the description why extensions are deprecated.

Refs: #25362

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
docs: add information about modules cache behavior
4b390c2
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 28, 2019

@BridgeAR Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 28, 2019
@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Mar 28, 2019

@nodejs/modules @nodejs/documentation PTAL

@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Mar 28, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3091/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
sagirk
sagirk approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@sagirksagirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nits! 🎉

sagirkand others added 2 commits March 31, 2019 12:49
@sagirk@BridgeAR
fixup!
3806b7e
Co-Authored-By: BridgeAR <[email protected]>
@sagirk@BridgeAR
fixup!
74b06dd
Co-Authored-By: BridgeAR <[email protected]>
@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Mar 31, 2019•
edited
Loading

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3119/ ✔️

@BridgeARBridgeAR changed the title docs: add information about modules cache behaviordoc: add information about modules cache behaviorMar 31, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 1, 2019
@BridgeAR
doc: add information about modules cache behavior
6eae414
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: nodejs#26971 Refs: nodejs#25362 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Apr 1, 2019

Landed in 6eae414.

@BridgeARBridgeAR closed this Apr 1, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@BridgeAR@BethGriggs
doc: add information about modules cache behavior
d5e440f
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@BridgeAR@BethGriggs
doc: add information about modules cache behavior
c43a03d
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@BridgeAR@BethGriggs
doc: add information about modules cache behavior
0f08a8e
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@BridgeAR@BethGriggs
doc: add information about modules cache behavior
0b94aec
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
@BridgeARBridgeAR deleted the improve-module-docs branch January 20, 2020 11:59
@baby636baby636 mentioned this pull request Jul 12, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sagirksagirksagirk approved these changes

@devsnekdevsnekdevsnek approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BridgeAR@nodejs-github-bot@sagirk@devsnek@vsemozhetbyt